Skip to content

Conversation

@st--
Copy link
Member

@st-- st-- commented May 8, 2023

Deprecates the approx_lml defined in this package in favour of AbstractGPs.approx_log_evidence (see JuliaGaussianProcesses/AbstractGPs.jl#361).

Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@st--
Copy link
Member Author

st-- commented May 9, 2023

hadn't looked so good to the CI 😅

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.35%. Comparing base (97675b1) to head (3f9b152).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/SparseVariationalApproximationModule.jl 0.00% 2 Missing ⚠️
src/LaplaceApproximationModule.jl 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (97675b1) and HEAD (3f9b152). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (97675b1) HEAD (3f9b152)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #145       +/-   ##
==========================================
- Coverage   93.35%   0.35%   -93.01%     
==========================================
  Files           4       5        +1     
  Lines         286     281        -5     
==========================================
- Hits          267       1      -266     
- Misses         19     280      +261     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@st--
Copy link
Member Author

st-- commented May 9, 2023

@willtebbutt any idea what's going on with the Julia 1 tests? 🤔

@willtebbutt
Copy link
Member

Hmm it looks like something going wrong in ChainRules / Zygote, but I definitely couldn't tell you what 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants